Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 69243005: Revert "Harden NumberToSize against overflows." (Closed)

Created:
7 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert "Harden NumberToSize against overflows." This reverts commit r17733 for breaking Linux build. TBR=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/v8conversions.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
Committed patchset #1 manually as r17734.
7 years, 1 month ago (2013-11-14 11:19:36 UTC) #1
Dmitry Lomov (no reviews)
7 years, 1 month ago (2013-11-14 11:23:45 UTC) #2
Jakob Kummerow
7 years, 1 month ago (2013-11-14 11:32:45 UTC) #3
Message was sent while issue was closed.
rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698