chrome/browser/chromeos/login/screens/device_disabled_screen.h - Issue 692383005: Add DeviceDisablingManager to manage device disabling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/device_disabled_screen.h

Issue 692383005: Add DeviceDisablingManager to manage device disabling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_3_425574_disable_header_bar

Patch Set: Move the parsing of the disabled message to DeviceDisablingManager as well. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screens/base_screen_delegate.h ('k') | chrome/browser/chromeos/login/screens/device_disabled_screen.cc » ('j') | chrome/browser/chromeos/system/device_disabling_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screens/device_disabled_screen.h

diff --git a/chrome/browser/chromeos/login/screens/device_disabled_screen.h b/chrome/browser/chromeos/login/screens/device_disabled_screen.h

index e9d2fe34cef7af6c720dbcde986f613e857aaab2..35bd8c173b968f39b73a38c729c5e9bf64887d78 100644

--- a/chrome/browser/chromeos/login/screens/device_disabled_screen.h

+++ b/chrome/browser/chromeos/login/screens/device_disabled_screen.h

@@ -6,7 +6,6 @@

#define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_DEVICE_DISABLED_SCREEN_H_

#include "base/macros.h"

-#include "base/memory/weak_ptr.h"

#include "chrome/browser/chromeos/login/screens/base_screen.h"

#include "chrome/browser/chromeos/login/screens/device_disabled_screen_actor.h"

@@ -32,17 +31,11 @@ class DeviceDisabledScreen : public BaseScreen,

void OnActorDestroyed(DeviceDisabledScreenActor* actor) override;

private:

- // Indicate to the observer that the screen was skipped because the device is

- // not disabled.

- void IndicateDeviceNotDisabled();

// Whether the screen is currently showing.

bool showing_;

DeviceDisabledScreenActor* actor_;

- base::WeakPtrFactory<DeviceDisabledScreen> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(DeviceDisabledScreen);

};