Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 692343003: dmprof expand command supports to analyze multiple components with same name in different allocators (Closed)

Created:
6 years, 1 month ago by wensheng
Modified:
6 years, 1 month ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

dmprof expand command supports to analyze multiple components with same name in different allocators Enhance the dmprof expand command to analyze multiple components with same name in different allocators. This can help to define policy by services, no need to divide by tc- and mmap-. R=kouhei@chromium.org BUG=427390 Committed: https://crrev.com/4eec2916da984c217cfaa66b19d7dd4970b6ec81 Cr-Commit-Position: refs/heads/master@{#304396}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Format codes #

Total comments: 2

Patch Set 3 : found #

Patch Set 4 : fix conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -51 lines) Patch
M tools/deep_memory_profiler/lib/policy.py View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M tools/deep_memory_profiler/subcommands/expand.py View 1 2 3 1 chunk +57 lines, -49 lines 0 comments Download

Messages

Total messages: 25 (8 generated)
wensheng
6 years, 1 month ago (2014-11-04 05:00:08 UTC) #1
kouhei (in TOK)
https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/lib/policy.py File tools/deep_memory_profiler/lib/policy.py (right): https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/lib/policy.py#newcode128 tools/deep_memory_profiler/lib/policy.py:128: def find_rule(self, component_name, follow_rule=None): follow_rule -> after? https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/lib/policy.py#newcode129 tools/deep_memory_profiler/lib/policy.py:129: ...
6 years, 1 month ago (2014-11-04 18:17:03 UTC) #2
wensheng
Thanks for your advice. https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/lib/policy.py File tools/deep_memory_profiler/lib/policy.py (right): https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/lib/policy.py#newcode128 tools/deep_memory_profiler/lib/policy.py:128: def find_rule(self, component_name, follow_rule=None): On ...
6 years, 1 month ago (2014-11-05 01:46:18 UTC) #3
kouhei (in TOK)
lgtm % nits https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profiler/lib/policy.py File tools/deep_memory_profiler/lib/policy.py (right): https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profiler/lib/policy.py#newcode134 tools/deep_memory_profiler/lib/policy.py:134: find_after_rule = False find -> found?
6 years, 1 month ago (2014-11-10 23:50:06 UTC) #5
wensheng
Thanks again. https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profiler/lib/policy.py File tools/deep_memory_profiler/lib/policy.py (right): https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profiler/lib/policy.py#newcode134 tools/deep_memory_profiler/lib/policy.py:134: find_after_rule = False On 2014/11/10 23:50:06, kouhei ...
6 years, 1 month ago (2014-11-11 02:50:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692343003/40001
6 years, 1 month ago (2014-11-11 02:52:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/79789) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/84718) chromium_presubmit ...
6 years, 1 month ago (2014-11-11 02:56:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692343003/40001
6 years, 1 month ago (2014-11-12 01:43:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/80310) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/33293)
6 years, 1 month ago (2014-11-12 01:46:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692343003/40001
6 years, 1 month ago (2014-11-17 05:07:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/82263) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/34672)
6 years, 1 month ago (2014-11-17 05:10:21 UTC) #18
kouhei (in TOK)
On 2014/11/17 05:10:21, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-17 05:14:51 UTC) #19
wensheng
On 2014/11/17 05:14:51, kouhei wrote: > On 2014/11/17 05:10:21, I haz the power (commit-bot) wrote: ...
6 years, 1 month ago (2014-11-17 07:23:35 UTC) #20
kouhei (in TOK)
lgtm
6 years, 1 month ago (2014-11-17 08:01:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692343003/60001
6 years, 1 month ago (2014-11-17 08:29:04 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-17 09:16:54 UTC) #24
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 09:17:42 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4eec2916da984c217cfaa66b19d7dd4970b6ec81
Cr-Commit-Position: refs/heads/master@{#304396}

Powered by Google App Engine
This is Rietveld 408576698