dmprof expand command supports to analyze multiple components with same name in different allocators

dmprof expand command supports to analyze multiple components with same name in different allocators

Enhance the dmprof expand command to analyze multiple components with same name in different allocators. This can help to define policy by services, no need to divide by tc- and mmap-.

R=kouhei@chromium.org
BUG=427390
Committed: https://crrev.com/4eec2916da984c217cfaa66b19d7dd4970b6ec81
Cr-Commit-Position: refs/heads/master@{#304396}

[kouhei (in TOK), 2014-11-04 18:17:03]

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
File tools/deep_memory_profiler/lib/policy.py (right):

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
tools/deep_memory_profiler/lib/policy.py:128: def find_rule(self,
component_name, follow_rule=None):
follow_rule -> after?

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
tools/deep_memory_profiler/lib/policy.py:129: """Finds a rule whose name is
|component_name|. """
Please update comment.

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
tools/deep_memory_profiler/lib/policy.py:130: flag = False
please use more descriptive variable name.

[wensheng, 2014-11-05 01:46:18]

Thanks for your advice.

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
File tools/deep_memory_profiler/lib/policy.py (right):

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
tools/deep_memory_profiler/lib/policy.py:128: def find_rule(self,
component_name, follow_rule=None):
On 2014/11/04 18:17:03, kouhei wrote:
> follow_rule -> after?

Yes

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
tools/deep_memory_profiler/lib/policy.py:129: """Finds a rule whose name is
|component_name|. """
On 2014/11/04 18:17:03, kouhei wrote:
> Please update comment.

Done.

https://codereview.chromium.org/692343003/diff/1/tools/deep_memory_profiler/l...
tools/deep_memory_profiler/lib/policy.py:130: flag = False
On 2014/11/04 18:17:03, kouhei wrote:
> please use more descriptive variable name.

Done.

[Dai Mikurube (NOT FULLTIME), 2014-11-05 03:26:03]

dmikurube@chromium.org changed reviewers:
+ dmikurube@chromium.org

[kouhei (in TOK), 2014-11-10 23:50:06]

lgtm % nits

https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profil...
File tools/deep_memory_profiler/lib/policy.py (right):

https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profil...
tools/deep_memory_profiler/lib/policy.py:134: find_after_rule = False
find -> found?

[wensheng, 2014-11-11 02:50:40]

Thanks again.

https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profil...
File tools/deep_memory_profiler/lib/policy.py (right):

https://codereview.chromium.org/692343003/diff/20001/tools/deep_memory_profil...
tools/deep_memory_profiler/lib/policy.py:134: find_after_rule = False
On 2014/11/10 23:50:06, kouhei wrote:
> find -> found?

Done.

[wensheng, 2014-11-11 02:51:21]

The CQ bit was checked by wensheng.he@samsung.com

[commit-bot: I haz the power, 2014-11-11 02:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692343003/40001

[commit-bot: I haz the power, 2014-11-11 02:56:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 02:56:13]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/79789)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/84718)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wensheng, 2014-11-12 01:42:16]

The CQ bit was checked by wensheng.he@samsung.com

[commit-bot: I haz the power, 2014-11-12 01:43:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692343003/40001

[commit-bot: I haz the power, 2014-11-12 01:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 01:46:17]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/80310)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[wensheng, 2014-11-17 05:07:29]

The CQ bit was checked by wensheng.he@samsung.com

[commit-bot: I haz the power, 2014-11-17 05:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692343003/40001

[commit-bot: I haz the power, 2014-11-17 05:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-17 05:10:21]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/82263)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kouhei (in TOK), 2014-11-17 05:14:51]

On 2014/11/17 05:10:21, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_gpu on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/82263)
>   mac_chromium_compile_dbg on tryserver.chromium.mac
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Would you rebaseline the patch?

[wensheng, 2014-11-17 07:23:35]

On 2014/11/17 05:14:51, kouhei wrote:
> On 2014/11/17 05:10:21, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   mac_gpu on tryserver.chromium.gpu
> >
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/82263)
> >   mac_chromium_compile_dbg on tryserver.chromium.mac
> >
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> 
> Would you rebaseline the patch?

Fixed, please take a look.
Sorry for interrupt.

[kouhei (in TOK), 2014-11-17 08:01:27]

lgtm

[wensheng, 2014-11-17 08:28:25]

The CQ bit was checked by wensheng.he@samsung.com

[commit-bot: I haz the power, 2014-11-17 08:29:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692343003/60001

[commit-bot: I haz the power, 2014-11-17 09:16:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-17 09:17:42]

Patchset 4 (id:??) landed as
https://crrev.com/4eec2916da984c217cfaa66b19d7dd4970b6ec81
Cr-Commit-Position: refs/heads/master@{#304396}