Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 692343002: Revert of [DevTools] Extract platform module. (Closed)

Created:
6 years, 1 month ago by lushnikov
Modified:
6 years, 1 month ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of [DevTools] Extract platform module. (patchset #4 id:40002 of https://codereview.chromium.org/673163004/) Reason for revert: This breaks DevTools at least in a hosted mode: the front-end does not load, exceptions are thrown from Runtime.js Original issue's description: > [DevTools] Extract platform module. > > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184753 TBR=apavlov@chromium.org,pfeldman@chromium.org,vsevik@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2444 lines, -2488 lines) Patch
M LayoutTests/inspector-protocol/heap-profiler/resources/heap-snapshot-common.js View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/initial-modules-load-expected.txt View 5 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/devtools.gypi View 6 chunks +5 lines, -10 lines 0 comments Download
M Source/devtools/front_end/Runtime.js View 9 chunks +111 lines, -72 lines 0 comments Download
M Source/devtools/front_end/bindings/module.json View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/common/Geometry.js View 1 chunk +0 lines, -75 lines 0 comments Download
M Source/devtools/front_end/common/module.json View 1 chunk +1 line, -3 lines 0 comments Download
A Source/devtools/front_end/common/utilities.js View 1 chunk +1426 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/module.json View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/devices/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/devtools.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/heap_snapshot_worker/module.json View 1 chunk +1 line, -2 lines 0 comments Download
A Source/devtools/front_end/host/DOMExtension.js View 1 chunk +853 lines, -0 lines 0 comments Download
A Source/devtools/front_end/host/ToolboxHost.js View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/devtools/front_end/host/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 chunk +0 lines, -1 line 0 comments Download
D Source/devtools/front_end/platform/DOMExtension.js View 1 chunk +0 lines, -779 lines 0 comments Download
D Source/devtools/front_end/platform/Promise.js View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/devtools/front_end/platform/module.json View 1 chunk +0 lines, -9 lines 0 comments Download
D Source/devtools/front_end/platform/utilities.js View 1 chunk +0 lines, -1437 lines 0 comments Download
M Source/devtools/front_end/promises/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/script_formatter_worker/module.json View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/module.json View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/toolbox.json View 1 chunk +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/toolbox/module.json View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 3 chunks +11 lines, -14 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/workspace/module.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
lushnikov
Created Revert of [DevTools] Extract platform module.
6 years, 1 month ago (2014-11-01 14:10:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692343002/1
6 years, 1 month ago (2014-11-01 14:11:19 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 14:12:26 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184772

Powered by Google App Engine
This is Rietveld 408576698