Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 692333011: Classes: Add support for arguments in default constructor (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Add support for arguments in default constructor This is currently done by generating a default constructor that looks like this: constructor() { %DefaultConstructorSuperCall(); } The a runtime function implements the logic which is pretty similar to Runtime_Apply except that it uses the [[Prototype]] of the current function. BUG=v8:3672 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25268

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -11 lines) Patch
M src/parser.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 1 chunk +25 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
arv (Not doing code reviews)
Dmitry, I know you said you wanted this to get inlined. Maybe it is still ...
6 years, 1 month ago (2014-11-11 01:44:09 UTC) #2
Dmitry Lomov (no reviews)
lgtm if an extra test added. Ok to keep it in runtime for now. Make ...
6 years, 1 month ago (2014-11-11 10:12:50 UTC) #3
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-11 15:54:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698