chrome/browser/apps/web_view_browsertest.cc - Issue 692333009: Fixed the problem at the source of the flaky WebViewTest.ShimArcAttribute test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 692333009: Fixed the problem at the source of the flaky WebViewTest.ShimArcAttribute test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fix. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/web_view_attributes.js » ('j') | extensions/renderer/resources/guest_view/web_view_attributes.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/web_view_browsertest.cc

diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc

index 3bd83954c3d6eeaba5fbf496bc1a91fcf18bec19..4f61be54fe0a15ace1c49fda9611fd67e14b7ade 100644

--- a/chrome/browser/apps/web_view_browsertest.cc

+++ b/chrome/browser/apps/web_view_browsertest.cc

@@ -1254,13 +1254,7 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, InterstitialTeardown) {

window->GetBaseWindow()->Close();

}

-#if defined(OS_LINUX)

-// http://crbug.com/431604

-#define MAYBE_ShimSrcAttribute DISABLED_ShimSrcAttribute

-#else

-#define MAYBE_ShimSrcAttribute ShimSrcAttribute

-#endif

-IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_ShimSrcAttribute) {

+IN_PROC_BROWSER_TEST_F(WebViewTest, ShimSrcAttribute) {

ASSERT_TRUE(RunPlatformAppTest("platform_apps/web_view/src_attribute"))

<< message_;

}