Fixed the problem at the source of the flaky WebViewTest.ShimArcAttribute test.

Fixed the source of the flakiness of the WebViewTest.ShimArcAttribute test.

BUG=431604
Committed: https://crrev.com/feeff71519070dddf09693c273bb4cd89c6168dc
Cr-Commit-Position: refs/heads/master@{#303529}

[paulmeyer, 2014-11-10 18:34:46]

paulmeyer@chromium.org changed reviewers:
+ lazyboy@chromium.org

[paulmeyer, 2014-11-10 18:34:47]

+lazyboy@

[Fady Samuel, 2014-11-10 18:40:17]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-11-10 18:40:17]

https://codereview.chromium.org/692333009/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/guest_view/web_view_attributes.js (right):

https://codereview.chromium.org/692333009/diff/1/extensions/renderer/resource...
extensions/renderer/resources/guest_view/web_view_attributes.js:200:
this.observer.takeRecords();
Could you please add a comment explaining why this is necessary. I just can't
remember.

[Fady Samuel, 2014-11-10 18:40:52]

Please re-enable the disabled test too please :-)

[paulmeyer, 2014-11-10 19:06:43]

ptal

[lazyboy, 2014-11-10 19:24:24]

lgtm

[Fady Samuel, 2014-11-10 19:25:39]

https://codereview.chromium.org/692333009/diff/40001/extensions/renderer/reso...
File extensions/renderer/resources/guest_view/web_view_attributes.js (right):

https://codereview.chromium.org/692333009/diff/40001/extensions/renderer/reso...
extensions/renderer/resources/guest_view/web_view_attributes.js:200: //
takeRecords() needed to clear queued up src mutations.
This doesn't explain why this was causing an issue. Could you add further
clarification?

[paulmeyer, 2014-11-10 19:35:48]

ptal

https://codereview.chromium.org/692333009/diff/40001/extensions/renderer/reso...
File extensions/renderer/resources/guest_view/web_view_attributes.js (right):

https://codereview.chromium.org/692333009/diff/40001/extensions/renderer/reso...
extensions/renderer/resources/guest_view/web_view_attributes.js:200: //
takeRecords() needed to clear queued up src mutations.
On 2014/11/10 19:25:39, Fady Samuel wrote:
> This doesn't explain why this was causing an issue. Could you add further
> clarification?

Done.

[Fady Samuel, 2014-11-10 21:13:27]

Horray for more general code! LGTM!

[paulmeyer, 2014-11-10 21:13:46]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-11-10 21:14:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692333009/80001

[commit-bot: I haz the power, 2014-11-10 21:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-10 21:50:00]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[paulmeyer, 2014-11-10 22:21:26]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-11-10 22:21:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692333009/100001

[commit-bot: I haz the power, 2014-11-10 23:11:01]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-10 23:11:41]

Patchset 6 (id:??) landed as
https://crrev.com/feeff71519070dddf09693c273bb4cd89c6168dc
Cr-Commit-Position: refs/heads/master@{#303529}