Move Liveness from DemuxerStreamProvider to DemuxerStream.

media/filters/video_renderer_impl.cc

Index: media/filters/video_renderer_impl.cc
diff --git a/media/filters/video_renderer_impl.cc b/media/filters/video_renderer_impl.cc
index 1bd3f270ab92bfaf7688d2b0713f9c7b15f226ec..ffd802f632f0def718efcce4adba1894dea7168b 100644
--- a/media/filters/video_renderer_impl.cc
+++ b/media/filters/video_renderer_impl.cc
@@ -107,7 +107,6 @@ void VideoRendererImpl::StartPlayingFrom(base::TimeDelta timestamp) {
 }
 
 void VideoRendererImpl::Initialize(DemuxerStream* stream,
-                                   bool low_delay,
                                    const PipelineStatusCB& init_cb,
                                    const StatisticsCB& statistics_cb,
                                    const BufferingStateCB& buffering_state_cb,
@@ -125,7 +124,7 @@ void VideoRendererImpl::Initialize(DemuxerStream* stream,
   DCHECK(!get_time_cb.is_null());
   DCHECK_EQ(kUninitialized, state_);
 
-  low_delay_ = low_delay;
+  low_delay_ = (stream->liveness() == DemuxerStream::LIVENESS_LIVE);

[wolenetz, 2014/11/11 23:48:07]

nit: This logic is now in multiple places (see also
DecoderStreamTraits<DemuxerStream::VIDEO>::InitializeDecoder(), and inverse in
VideoRendererImplTest::CallInitialize()). Can some of this be simplified (maybe
as a static method in DemuxerStream such as:
static bool is_low_delay(Liveness liveness) { return liveness == LIVENESS_LIVE;
} ) ?

[xhwang, 2014/11/14 06:38:04]

Hmm, I don't feel

DemuxerStream::is_low_delay(stream->liveness)

is much better than 

stream->liveness() == DemuxerStream::LIVENESS_LIVE

Maybe we don't need liveness at all in DemuxerStream. A boolean "low_delay"
would suffice.

I'll like to iterate on this later.

[wolenetz, 2014/11/14 19:21:58]

Acknowledged.

 
   // Always post |init_cb_| because |this| could be destroyed if initialization
   // failed.
@@ -139,9 +138,7 @@ void VideoRendererImpl::Initialize(DemuxerStream* stream,
   state_ = kInitializing;
 
   video_frame_stream_->Initialize(
-      stream,
-      low_delay,
-      statistics_cb,
+      stream, statistics_cb,
       base::Bind(&VideoRendererImpl::OnVideoFrameStreamInitialized,
                  weak_factory_.GetWeakPtr()));
 }