Allow uncaught exception messaging in Object.observe callbacks.

Allow uncaught exception messaging in Object.observe callbacks.

This also naturally handles pausing on uncaught exceptions in Object.observe callbacks.

R=adamk@chromium.org, yangguo@chromium.org, yurys@chromium.org
BUG=chromium:335660
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=25126

[aandrey, 2014-11-01 15:30:51]

https://codereview.chromium.org/692313003/diff/1/test/cctest/test-object-obse...
File test/cctest/test-object-observe.cc (right):

https://codereview.chromium.org/692313003/diff/1/test/cctest/test-object-obse...
test/cctest/test-object-observe.cc:161: TEST(DeliveryChangesMutationInCallback)
{
this test is not related to the current patch, but to the further optimization
TODO (see changes in object-observe.js).

[aandrey, 2014-11-01 15:36:25]

aandrey@chromium.org changed reviewers:
+ rossberg@chromium.org

[aandrey, 2014-11-01 16:30:17]

Debug build is failing on a DCHECK:

Fatal error in ../src/execution.cc, line 112
# CHECK(has_exception == isolate->has_pending_exception()) failed

Is it safe to remove it?

[aandrey, 2014-11-02 13:06:43]

On 2014/11/01 16:30:17, aandrey wrote:
> Debug build is failing on a DCHECK:
> 
> Fatal error in ../src/execution.cc, line 112
> # CHECK(has_exception == isolate->has_pending_exception()) failed
> 
> Is it safe to remove it?

I think I've nailed it. PTAL.

[Yang, 2014-11-03 12:31:27]

On 2014/11/02 13:06:43, aandrey wrote:
> On 2014/11/01 16:30:17, aandrey wrote:
> > Debug build is failing on a DCHECK:
> > 
> > Fatal error in ../src/execution.cc, line 112
> > # CHECK(has_exception == isolate->has_pending_exception()) failed
> > 
> > Is it safe to remove it?
> 
> I think I've nailed it. PTAL.

I assume this is to replace https://codereview.chromium.org/653023004/

This solution is indeed more elegant than what I had in mind. LGTM!

[Yang, 2014-11-03 12:31:35]

https://codereview.chromium.org/692313003/diff/80001/src/runtime/runtime-obse...
File src/runtime/runtime-observe.cc (right):

https://codereview.chromium.org/692313003/diff/80001/src/runtime/runtime-obse...
src/runtime/runtime-observe.cc:61: // We should send a message on uncaught
exception happenned during
s/happenned/thrown/

[adamk, 2014-11-04 23:43:52]

lgtm, though I wonder how much of a perf hit due to the extra js -> c++ -> js
jumps.

[aandrey, 2014-11-05 07:23:11]

On 2014/11/04 23:43:52, adamk wrote:
> lgtm, though I wonder how much of a perf hit due to the extra js -> c++ -> js
> jumps.

I think once the TODO is addressed, perf should be even better than before, as
it will look as if we removed one %_CallFunction() call (although AFAIU it's an
inlined call).

[aandrey, 2014-11-05 07:23:39]

Committed patchset #6 (id:90001) manually as 25126 (presubmit successful).