Chromium Code Reviews Chromium Code Reviews
Issue 692313002:
Disable -Wextra for all toolchains. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: build/common.gypi |
| diff --git a/build/common.gypi b/build/common.gypi |
| index b8a87e09c707e3b6bc7cf47fcd41bbcdd8499e9a..d42fc2a444d33dfc70a15d50cf74700f1a7a2dd0 100644 |
| --- a/build/common.gypi |
| +++ b/build/common.gypi |
| @@ -3546,6 +3546,13 @@ |
| '-Wno-unused-parameter', |
| # Don't warn about the "struct foo f = {0};" initialization pattern. |
| '-Wno-missing-field-initializers', |
| + # Don't warn if a comparison is always true or always false due to |
| + # the limited range of the data type. This would be nice to do, but |
| + # unfortunately, 'char' is signed on some toolchains and unsigned on |
| + # others. There are downsides to forcing it to be one or the other. |
| + # Forcing signed makes ARM builds less performant, and Windows builds |
| + # fail if we force unsigned. |
| + '-Wno-type-limits', |
|
Nico
2014/11/03 20:42:38
You only want to add this for gcc builds. clang bu
|
| # Don't export any symbols (for example, to plugins we dlopen()). |
| # Note: this is *required* to make some plugins work. |
| '-fvisibility=hidden', |
