Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: build/common.gypi

Issue 692313002: Disable -Wextra for all toolchains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add -Wno-type-limits to GYP build Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3528 matching lines...) Expand 10 before | Expand all | Expand 10 after
3539 '<(werror)', # See note above about the werror variable. 3539 '<(werror)', # See note above about the werror variable.
3540 '-pthread', 3540 '-pthread',
3541 '-fno-strict-aliasing', # See http://crbug.com/32204 3541 '-fno-strict-aliasing', # See http://crbug.com/32204
3542 '-Wall', 3542 '-Wall',
3543 # TODO(evan): turn this back on once all the builds work. 3543 # TODO(evan): turn this back on once all the builds work.
3544 # '-Wextra', 3544 # '-Wextra',
3545 # Don't warn about unused function params. We use those everywhere. 3545 # Don't warn about unused function params. We use those everywhere.
3546 '-Wno-unused-parameter', 3546 '-Wno-unused-parameter',
3547 # Don't warn about the "struct foo f = {0};" initialization pattern. 3547 # Don't warn about the "struct foo f = {0};" initialization pattern.
3548 '-Wno-missing-field-initializers', 3548 '-Wno-missing-field-initializers',
3549 # Don't warn if a comparison is always true or always false due to
3550 # the limited range of the data type. This would be nice to do, but
3551 # unfortunately, 'char' is signed on some toolchains and unsigned on
3552 # others. There are downsides to forcing it to be one or the other.
3553 # Forcing signed makes ARM builds less performant, and Windows builds
3554 # fail if we force unsigned.
3555 '-Wno-type-limits',
Nico 2014/11/03 20:42:38 You only want to add this for gcc builds. clang bu
3549 # Don't export any symbols (for example, to plugins we dlopen()). 3556 # Don't export any symbols (for example, to plugins we dlopen()).
3550 # Note: this is *required* to make some plugins work. 3557 # Note: this is *required* to make some plugins work.
3551 '-fvisibility=hidden', 3558 '-fvisibility=hidden',
3552 '-pipe', 3559 '-pipe',
3553 ], 3560 ],
3554 'cflags_cc': [ 3561 'cflags_cc': [
3555 '-fno-exceptions', 3562 '-fno-exceptions',
3556 '-fno-rtti', 3563 '-fno-rtti',
3557 '-fno-threadsafe-statics', 3564 '-fno-threadsafe-statics',
3558 # Make inline functions have hidden visiblity by default. 3565 # Make inline functions have hidden visiblity by default.
(...skipping 2322 matching lines...) Expand 10 before | Expand all | Expand 10 after
5881 # settings in target dicts. SYMROOT is a special case, because many other 5888 # settings in target dicts. SYMROOT is a special case, because many other
5882 # Xcode variables depend on it, including variables such as 5889 # Xcode variables depend on it, including variables such as
5883 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5890 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5884 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5891 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5885 # files to appear (when present) in the UI as actual files and not red 5892 # files to appear (when present) in the UI as actual files and not red
5886 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5893 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5887 # and therefore SYMROOT, needs to be set at the project level. 5894 # and therefore SYMROOT, needs to be set at the project level.
5888 'SYMROOT': '<(DEPTH)/xcodebuild', 5895 'SYMROOT': '<(DEPTH)/xcodebuild',
5889 }, 5896 },
5890 } 5897 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698