Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 692303002: Add DPI option selection to Print Preview. (Closed)

Created:
6 years, 1 month ago by Aleksey Shlyapnikov
Modified:
6 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add DPI option selection to Print Preview. BUG=429393 Committed: https://crrev.com/995f4f0dafffd3c491b38d55cafbda2dff6adff2 Cr-Commit-Position: refs/heads/master@{#302497}

Patch Set 1 #

Patch Set 2 : Do not show DPI selection if there's only one option available. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -146 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/data/app_state.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 4 chunks +25 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/data/ticket_items/dpi.js View 1 1 chunk +82 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 6 chunks +15 lines, -0 lines 0 comments Download
A + chrome/browser/resources/print_preview/settings/dpi_settings.css View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/print_preview/settings/dpi_settings.html View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/dpi_settings.js View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.js View 1 chunk +5 lines, -121 lines 0 comments Download
A + chrome/browser/resources/print_preview/settings/settings_section_select.js View 6 chunks +30 lines, -21 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Aleksey Shlyapnikov
6 years, 1 month ago (2014-11-01 03:25:50 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 1 month ago (2014-11-03 19:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692303002/20001
6 years, 1 month ago (2014-11-03 20:04:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-03 22:14:33 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:15:13 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/995f4f0dafffd3c491b38d55cafbda2dff6adff2
Cr-Commit-Position: refs/heads/master@{#302497}

Powered by Google App Engine
This is Rietveld 408576698