Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 692253002: Clean up SkyElement (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
rafaelw
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Clean up SkyElement There's no reason to wrap this script in an anonymous function. Sky modules already run inside their own scope. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/80de599c297342a8d0f1f15491ac0007cdc30521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -55 lines) Patch
M sky/framework/sky-element/sky-element.sky View 1 chunk +46 lines, -55 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-31 21:57:17 UTC) #1
rafaelw
lgtm. I unwrapped a bunch of others -- sorry I missed this one.
6 years, 1 month ago (2014-10-31 21:58:16 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-31 21:58:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80de599c297342a8d0f1f15491ac0007cdc30521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698