Issue 692253002: Clean up SkyElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 692253002: Clean up SkyElement (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
rafaelw

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Clean up SkyElement There's no reason to wrap this script in an anonymous function. Sky modules already run inside their own scope. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/80de599c297342a8d0f1f15491ac0007cdc30521

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -55 lines)			Patch
	M	sky/framework/sky-element/sky-element.sky	View		1 chunk	+46 lines, -55 lines	0 comments	Download

Total messages: 3 (0 generated)

rafaelw

lgtm. I unwrapped a bunch of others -- sorry I missed this one.

6 years, 1 month ago (2014-10-31 21:58:16 UTC) #2

abarth-chromium

6 years, 1 month ago (2014-10-31 21:58:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
80de599c297342a8d0f1f15491ac0007cdc30521 (presubmit successful).