Issue 692213004: Use better error message for an HTMLMediaElement that has already been connected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 692213004: Use better error message for an HTMLMediaElement that has already been connected. (Closed)

Created:
6 years, 1 month ago by Raymond Toy

Modified:
6 years, 1 month ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Use better error message for an HTMLMediaElement that has already been connected. The new error message makes it clear why createMediaElementSource is throwing an error instead of the previous generic "invalid". Also simplify the layout test implementation to also show the errors thrown. No functional changes. BUG=429204 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184797

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -57 lines)			Patch
M	LayoutTests/webaudio/mediaelementaudiosourcenode.html	View	1 chunk	+12 lines, -49 lines	0 comments	Download
M	LayoutTests/webaudio/mediaelementaudiosourcenode-expected.txt	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	Source/modules/webaudio/AudioContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692213004/1

6 years, 1 month ago (2014-11-03 19:44:01 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 19:46:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184797

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages