Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 692163002: Fix urls under /sky to work again (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix urls under /sky to work again Turns out that the /sky mapping to the gen directory was interfering with our new pattern of mapping the actual /sky directory. So now we use a more restrictive mapping pattern of only mapping /sky/services, similar for /mojo/services and /mojo/public. Fixed an exception of not finding _sky_server when a custom sky_server was already running. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b58fdff403eb92ba0207e38b529d7a96e28c5954

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M sky/tools/sky_server View 1 chunk +6 lines, -7 lines 1 comment Download
M sky/tools/skydb View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
6 years, 1 month ago (2014-10-31 18:42:47 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/692163002/diff/1/sky/tools/sky_server File sky/tools/sky_server (right): https://codereview.chromium.org/692163002/diff/1/sky/tools/sky_server#newcode72 sky/tools/sky_server:72: '/mojo/public': { /mojo/services
6 years, 1 month ago (2014-10-31 18:43:39 UTC) #2
ojan
Should we keep apache_http.py in sync with these changes?
6 years, 1 month ago (2014-10-31 18:44:45 UTC) #3
eseidel
6 years, 1 month ago (2014-10-31 18:46:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b58fdff403eb92ba0207e38b529d7a96e28c5954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698