Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 692153002: Replace custom code by hasOneTextChild API (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
Reviewers:
haraken, adamk
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace custom code by hasOneTextChild API This code just is the hasOneTextChild logic, so to avoid confusion use that instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184843

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove obvious comment #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/core/html/HTMLOptionElement.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rwlbuis
PTAL
6 years, 1 month ago (2014-10-31 19:13:48 UTC) #2
adamk
https://codereview.chromium.org/692153002/diff/1/Source/core/html/HTMLOptionElement.cpp File Source/core/html/HTMLOptionElement.cpp (right): https://codereview.chromium.org/692153002/diff/1/Source/core/html/HTMLOptionElement.cpp#newcode135 Source/core/html/HTMLOptionElement.cpp:135: // Handle the common special case where there's exactly ...
6 years, 1 month ago (2014-11-04 00:56:57 UTC) #4
rwlbuis
On 2014/11/04 00:56:57, adamk wrote: > https://codereview.chromium.org/692153002/diff/1/Source/core/html/HTMLOptionElement.cpp > File Source/core/html/HTMLOptionElement.cpp (right): > > https://codereview.chromium.org/692153002/diff/1/Source/core/html/HTMLOptionElement.cpp#newcode135 > ...
6 years, 1 month ago (2014-11-04 17:36:22 UTC) #5
haraken
LGTM https://codereview.chromium.org/692153002/diff/20001/Source/core/html/HTMLOptionElement.cpp File Source/core/html/HTMLOptionElement.cpp (right): https://codereview.chromium.org/692153002/diff/20001/Source/core/html/HTMLOptionElement.cpp#newcode135 Source/core/html/HTMLOptionElement.cpp:135: if (hasOneTextChild()) Nit: Add { } because the ...
6 years, 1 month ago (2014-11-04 18:02:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692153002/40001
6 years, 1 month ago (2014-11-04 20:24:38 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 22:45:21 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 184843

Powered by Google App Engine
This is Rietveld 408576698