Disable WebViewInteractiveTest.NewWindow_OpenInNewTab on OS_MACOSX, until the problem to miss keyup…

Disable WebViewInteractiveTest.NewWindow_OpenInNewTab on OS_MACOSX, until the problem to miss keyup event with command key is fixed

BUG=425859
R=avi@chromium.org
R=lazyboy@chromium.org

Committed: https://crrev.com/6d8de1a2a4a18e9629681be494434924cb9d46ad
Cr-Commit-Position: refs/heads/master@{#302397}

[Miyoung Shin, 2014-10-31 16:28:15]

myid.shin@samsung.com changed reviewers:
+ rsesek@chromium.org
- lazyboy@chromium.org

[Miyoung Shin, 2014-10-31 16:28:51]

avi@, rsesek@ PTAL

[Avi (use Gerrit), 2014-10-31 16:32:35]

LGTM with grammar.

https://codereview.chromium.org/692113002/diff/1/chrome/browser/apps/web_view...
File chrome/browser/apps/web_view_interactive_browsertest.cc (right):

https://codereview.chromium.org/692113002/diff/1/chrome/browser/apps/web_view...
chrome/browser/apps/web_view_interactive_browsertest.cc:852: // See
http://crbug.com/425859 for more information
Make your comments complete sentences, ending with periods. Can you clean the
grammar a bit?

// There is a problem of missing keyup events with the command key after
// the NSEvent is sent to NSApplication in ui/base/test/ui_controls_mac.mm .
// This test is disabled on only the Mac until the problem is resolved.
// See http://crbug.com/425859 for more information.

[Miyoung Shin, 2014-11-01 01:22:24]

On 2014/10/31 16:32:35, Avi wrote:
> LGTM with grammar.
> 
>
https://codereview.chromium.org/692113002/diff/1/chrome/browser/apps/web_view...
> File chrome/browser/apps/web_view_interactive_browsertest.cc (right):
> 
>
https://codereview.chromium.org/692113002/diff/1/chrome/browser/apps/web_view...
> chrome/browser/apps/web_view_interactive_browsertest.cc:852: // See
> http://crbug.com/425859 for more information
> Make your comments complete sentences, ending with periods. Can you clean the
> grammar a bit?
> 
> // There is a problem of missing keyup events with the command key after
> // the NSEvent is sent to NSApplication in ui/base/test/ui_controls_mac.mm .
> // This test is disabled on only the Mac until the problem is resolved.
> // See http://crbug.com/425859 for more information.

I did. can I commit it?

[Avi (use Gerrit), 2014-11-01 05:25:35]

On 2014/11/01 01:22:24, Miyoung Shin wrote:
> On 2014/10/31 16:32:35, Avi wrote:
> > LGTM with grammar.
> > 
> >
>
https://codereview.chromium.org/692113002/diff/1/chrome/browser/apps/web_view...
> > File chrome/browser/apps/web_view_interactive_browsertest.cc (right):
> > 
> >
>
https://codereview.chromium.org/692113002/diff/1/chrome/browser/apps/web_view...
> > chrome/browser/apps/web_view_interactive_browsertest.cc:852: // See
> > http://crbug.com/425859 for more information
> > Make your comments complete sentences, ending with periods. Can you clean
the
> > grammar a bit?
> > 
> > // There is a problem of missing keyup events with the command key after
> > // the NSEvent is sent to NSApplication in ui/base/test/ui_controls_mac.mm .
> > // This test is disabled on only the Mac until the problem is resolved.
> > // See http://crbug.com/425859 for more information.
> 
> I did. can I commit it?

To commit something, you need approval of an OWNER of the code. I'm not an
owner, so my LGTM doesn't count. I'm pretty sure rsesek isn't an OWNER either.

See http://www.chromium.org/developers/owners-files . You asked the wrong people
to review your change.

[Miyoung Shin, 2014-11-01 07:50:06]

myid.shin@samsung.com changed reviewers:
+ lazyboy@chromium.org

[Miyoung Shin, 2014-11-01 07:50:43]

lazyboy@, PTAL

[lazyboy, 2014-11-01 08:12:44]

lgtm

[Miyoung Shin, 2014-11-02 08:25:23]

The CQ bit was checked by myid.shin@samsung.com

[commit-bot: I haz the power, 2014-11-02 08:26:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692113002/20001

[commit-bot: I haz the power, 2014-11-02 09:56:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-02 09:57:43]

Patchset 2 (id:??) landed as
https://crrev.com/6d8de1a2a4a18e9629681be494434924cb9d46ad
Cr-Commit-Position: refs/heads/master@{#302397}