Crash component: adds API for clients to handle the crash minidump.

components/crash/app/crash_reporter_client.h

Index: components/crash/app/crash_reporter_client.h
diff --git a/components/crash/app/crash_reporter_client.h b/components/crash/app/crash_reporter_client.h
index 4032bd199d790a54047b1e80156becb91e216870..43f05e884d77611cd5fb4ba3ad42961baaf40c1b 100644
--- a/components/crash/app/crash_reporter_client.h
+++ b/components/crash/app/crash_reporter_client.h
@@ -103,6 +103,11 @@ class CrashReporterClient {
                                         const char** version);
 
   virtual base::FilePath GetReporterLogFilename();
+
+  // Custom crash minidump handler after the minidump is generated.
+  // Returns true if the minidump is handled (client); otherwise, return false
+  // to fallback to default handler.
+  virtual bool HandleCrashDump(const char* crashdump_filename);

[Robert Sesek, 2014/11/03 22:08:58]

This should be a base::FilePath.

[gunsch, 2014/11/03 22:11:41]

Hmm, I thought the crash code went to pretty great lengths to not allocate
anything new during crash-handling time, even things as simple as std::string.
What makes FilePath okay in this case?

[Robert Sesek, 2014/11/03 22:19:02]

In the crashed context that's definitely true. Is this code going to run in a
crashed context? Are you going to enforce the non-allocating requirement on API
consumers?

[gunsch, 2014/11/03 23:40:15]

The code path I'm invoking this from in breakpad_linux.cc runs in a compromised
context (CrashDone --> HandleCrashDump -->
CrashReporterClient::HandleCrashDump). I don't feel like there would be a way to
allow a content embedder to handle the crash dump outside of a crashed context.

I can document this fact (added), but I can't really "enforce" the requirement,
no?

[Robert Sesek, 2014/11/05 18:37:23]

It depends on the crash type. A renderer crash is handled by the browser, for
example.
You can't really enforce it, no. At some point, the allocator object in
HandleCrashDump may be a good parameter to pass, but it's not required yet.

 #endif
 
   // The location where minidump files should be written. Returns true if