Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 692083003: Revert of Roll src/third_party/skia d8aa7b7:2100c5e (Closed)

Created:
6 years, 1 month ago by Matt Perry
Modified:
6 years, 1 month ago
Reviewers:
hcm, skia-deps-roller
CC:
chromium-reviews, hcm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia d8aa7b7:2100c5e (patchset #1 id:1 of https://codereview.chromium.org/689093002/) Reason for revert: Speculative revert after lots of tests started crashing: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/33526 Failed steps failed app_shell_browsertests failed app_shell_unittests failed aura_unittests failed cc_unittests failed components_unittests failed compositor_unittests failed extensions_unittests failed views_unittests failed wm_unittests failed telemetry_unittests failed telemetry_perf_unittests failed browser_tests on windows-5.1 failed content_browsertests on windows-5.1 failed content_unittests on windows-5.1 failed interactive_ui_tests on windows-5.1 failed sync_integration_tests on windows-5.1 failed unit_tests on windows-5.1 Original issue's description: > Roll src/third_party/skia d8aa7b7:2100c5e > > Summary of changes available at: > https://chromium.googlesource.com/skia/+log/d8aa7b7..2100c5e > > CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg > TBR=hcm@google.com > > Committed: https://crrev.com/05712e1e61e7fff62b359e80a294caab7a4fa2ee > Cr-Commit-Position: refs/heads/master@{#302266} TBR=hcm@google.com,skia-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Matt Perry
Created Revert of Roll src/third_party/skia d8aa7b7:2100c5e
6 years, 1 month ago (2014-10-31 16:44:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692083003/1
6 years, 1 month ago (2014-10-31 16:44:58 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 16:45:36 UTC) #4
Failed to apply patch for DEPS:
While running git apply --index -3 -p1;
  error: patch failed: DEPS:44
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: DEPS: patch does not apply

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
4c8d69d99c8d386e1e5c1ba211b557ebbfe22987..03215f619daa1e70ded5447c354269d248a75891
100644
--- a/DEPS
+++ b/DEPS
@@ -44,7 +44,7 @@
   'boringssl_git': 'https://boringssl.googlesource.com',
   'libvpx_revision': '2e5ced5fd62a73f4f5687ab19520b3aad1c53f6f',
   'sfntly_revision': '1bdaae8fc788a5ac8936d68bf24f37d977a13dac',
-  'skia_revision': '2100c5ed7a5e5470a04e7af7309d8bd3fc4249f7',
+  'skia_revision': 'd8aa7b74c8ef0cb8ed3f6b03beb7ee5013624372',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling Skia
   # and V8 without interference from each other.

Powered by Google App Engine
This is Rietveld 408576698