Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 692083002: SK_USE_SCALED_FONTMETRICS for correct scaling (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SK_USE_SCALED_FONTMETRICS for correct scaling related blink change: https://codereview.chromium.org/691133002 Committed: https://skia.googlesource.com/skia/+/c17c6582ec0b7bc211d7de9e8d634692d239c123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
1. land this 2. land a guarded fix to blink 3. defined this flag in ...
6 years, 1 month ago (2014-10-31 15:00:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692083002/1
6 years, 1 month ago (2014-10-31 15:01:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-31 15:01:07 UTC) #5
bungeman-skia
lgtm, but I think the process should be: 1. Land this CL. 2. Roll this ...
6 years, 1 month ago (2014-10-31 15:18:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 15:20:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as c17c6582ec0b7bc211d7de9e8d634692d239c123

Powered by Google App Engine
This is Rietveld 408576698