Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 692073003: DevTools: [SSP] update style rules of SectionPropertyTreeElements (Closed)

Created:
6 years, 1 month ago by lushnikov
Modified:
6 years, 1 month ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] update style rules of SectionPropertyTreeElements The style rules of tree elements became outdated after the rule was edited. This patch adds synchronization for them as well. BUG=430133 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184869

Patch Set 1 #

Total comments: 1

Patch Set 2 : simplistic approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -3 lines) Patch
A LayoutTests/inspector/elements/styles/styles-disable-property-after-selector-edit.html View 1 chunk +55 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/styles/styles-disable-property-after-selector-edit-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
lushnikov
Please, take a look
6 years, 1 month ago (2014-11-04 18:09:30 UTC) #1
vsevik
lgtm https://codereview.chromium.org/692073003/diff/1/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/692073003/diff/1/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1865 Source/devtools/front_end/elements/StylesSidebarPane.js:1865: _propogateNewStyle: function(newStyle) propagate
6 years, 1 month ago (2014-11-05 07:52:05 UTC) #2
vsevik
Please check why did it work for toggling two properties in one rule before and ...
6 years, 1 month ago (2014-11-05 07:52:48 UTC) #3
lushnikov
The concept changed A LOT; please, take another look
6 years, 1 month ago (2014-11-05 10:24:12 UTC) #4
vsevik
lgtm
6 years, 1 month ago (2014-11-05 10:56:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692073003/20001
6 years, 1 month ago (2014-11-05 10:56:44 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 13:02:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184869

Powered by Google App Engine
This is Rietveld 408576698