Source/bindings/core/v8/WorkerScriptController.h - Issue 692003002: ServiceWorker: Registering a malformed script should fail [1/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WorkerScriptController.h

Issue 692003002: ServiceWorker: Registering a malformed script should fail [1/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address tkent@'s comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/WorkerScriptController.h

diff --git a/Source/bindings/core/v8/WorkerScriptController.h b/Source/bindings/core/v8/WorkerScriptController.h

index a947ec0e68004c81cb7249178e2039ce32aad344..de3007b7870b3c5564b22463b7e7a67c8415ca95 100644

--- a/Source/bindings/core/v8/WorkerScriptController.h

+++ b/Source/bindings/core/v8/WorkerScriptController.h

@@ -52,7 +52,7 @@ public:

bool isExecutionForbidden() const;

bool isExecutionTerminating() const;

- void evaluate(const ScriptSourceCode&, RefPtrWillBeRawPtr<ErrorEvent>* = 0);

+ bool evaluate(const ScriptSourceCode&, RefPtrWillBeRawPtr<ErrorEvent>* = 0);

yhirano 2014/11/05 03:41:10 // Returns true if the evaluation is done successf

nhiroki 2014/11/05 05:33:40 Done.

// Prevents future JavaScript execution. See

// scheduleExecutionTermination, isExecutionForbidden.

« no previous file with comments | « no previous file | Source/bindings/core/v8/WorkerScriptController.cpp » ('j') | public/web/WebServiceWorkerContextClient.h » ('J')