ServiceWorker: Registering a malformed script should fail [1/3]

Source/core/workers/WorkerReportingProxy.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 
 #include "core/frame/ConsoleTypes.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Forward.h"
 
 namespace blink {
 
 class ConsoleMessage;
 class WorkerGlobalScope;
 
 // APIs used by workers to report console activity.

[falken, 2014/11/04 05:41:26]

this looks out of date now... "console and worker activity"?

[nhiroki, 2014/11/04 09:03:11]

Done.

 class WorkerReportingProxy {
 public:
     virtual ~WorkerReportingProxy() { }
 
     virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL) = 0;
     virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) = 0;
     virtual void postMessageToPageInspector(const String&) = 0;
 
+    // Invoked when the worker script is evaluated. |result| is true if the
+    // evaluation succeeded.

[falken, 2014/11/04 05:41:26]

One might wonder what it means for an evaluation to "succeed", maybe say
"evaluation completed with no uncaught exception"

[nhiroki, 2014/11/04 09:03:11]

Right, "succeed" is not descriptive. Rephrased.

+    virtual void workerScriptEvaluated(bool result) = 0;

[falken, 2014/11/04 05:41:26]

"result" is not so clear of a name, how about bool success?

[nhiroki, 2014/11/04 09:03:11]

Done.

+
     // Invoked when the new WorkerGlobalScope is started.
     virtual void workerGlobalScopeStarted(WorkerGlobalScope*) = 0;
 
     // Invoked when close() is invoked on the worker context.
     virtual void workerGlobalScopeClosed() = 0;
 
     // Invoked when the thread is stopped and WorkerGlobalScope is being
     // destructed. (This is be the last method that is called on this
     // interface)
     virtual void workerThreadTerminated() = 0;
 
     // Invoked when the thread is about to be stopped and WorkerGlobalScope
     // is to be destructed. (When this is called it is guaranteed that
     // WorkerGlobalScope is still alive)
     virtual void willDestroyWorkerGlobalScope() = 0;
 };
 
 } // namespace blink
 
 #endif // WorkerReportingProxy_h