Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 691913003: fix RLZ crasher in process_info.cc (Closed)

Created:
6 years, 1 month ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

fix RLZ crasher in process_info.cc RLZ is using a very convoluted and fragile way to check for code running as NT/SYSTEM. - It can fail, which causes a crash - It is quite slow on domains - It is incorrect because "SYSTEM" is not the string in some locales. BUG=428944 Committed: https://crrev.com/feb83154301ec37a3839ab3e1604de5c4de6b264 Cr-Commit-Position: refs/heads/master@{#302741}

Patch Set 1 #

Patch Set 2 : includes #

Patch Set 3 : string16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -75 lines) Patch
M rlz/win/lib/process_info.cc View 1 2 2 chunks +8 lines, -75 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
cpu_(ooo_6.6-7.5)
ptal ps. I'll trim the headers if I can.
6 years, 1 month ago (2014-10-30 22:24:02 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm Thanks Carlos.
6 years, 1 month ago (2014-10-30 22:33:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691913003/1
6 years, 1 month ago (2014-10-31 01:17:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21419)
6 years, 1 month ago (2014-10-31 01:21:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691913003/20001
6 years, 1 month ago (2014-11-05 00:50:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22174)
6 years, 1 month ago (2014-11-05 00:58:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691913003/40001
6 years, 1 month ago (2014-11-05 01:17:12 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 02:02:58 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 02:03:31 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/feb83154301ec37a3839ab3e1604de5c4de6b264
Cr-Commit-Position: refs/heads/master@{#302741}

Powered by Google App Engine
This is Rietveld 408576698