Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 691903002: Fix return type of SetProcessDpiAwareness aka SetProcessDpiAwarenessInternal (Closed)

Created:
6 years, 1 month ago by brucedawson
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews; girard_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix return type of SetProcessDpiAwareness aka SetProcessDpiAwarenessInternal This function (documented as SetProcessDpiAwareness but exported as SetProcessDpiAwarenessInternal) has a return type of HRESULT but we declared it as returning BOOL. This triggered the following /analyze warning: src\chrome\app\chrome_exe_main_win.cc(104) : warning C6216: Compiler-inserted cast between semantically different integral types: a Boolean type to HRESULT. BUG=427616 Committed: https://crrev.com/592f8e1b305c8a67abe130210818b78d188df8b3 Cr-Commit-Position: refs/heads/master@{#302212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/chrome_exe_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
6 years, 1 month ago (2014-10-30 21:01:08 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-10-31 01:39:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691903002/1
6 years, 1 month ago (2014-10-31 01:40:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 02:23:34 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 02:24:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/592f8e1b305c8a67abe130210818b78d188df8b3
Cr-Commit-Position: refs/heads/master@{#302212}

Powered by Google App Engine
This is Rietveld 408576698