Issue 691893002: Add support for Element#getAttributes

Issue 691893002: Add support for Element#getAttributes (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add support for Element#getAttributes As described in //sky/specs/apis.md R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bb10867436d7cf66a21af1508f0e1802f5d4c2cc

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -6 lines)			Patch
M	sky/engine/core/dom/Element.h	View	1 chunk	+2 lines, -0 lines	2 comments	Download
M	sky/engine/core/dom/Element.cpp	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.idl	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/tests/lowlevel/attribute-collection.sky	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sky/tests/lowlevel/attribute-collection-expected.txt	View	1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm https://codereview.chromium.org/691893002/diff/1/sky/engine/core/dom/Element.h File sky/engine/core/dom/Element.h (right): https://codereview.chromium.org/691893002/diff/1/sky/engine/core/dom/Element.h#newcode94 sky/engine/core/dom/Element.h:94: Vector<RefPtr<Attr>> getAttributes(); const

6 years, 1 month ago (2014-10-30 20:53:09 UTC) #1

abarth-chromium

https://codereview.chromium.org/691893002/diff/1/sky/engine/core/dom/Element.h File sky/engine/core/dom/Element.h (right): https://codereview.chromium.org/691893002/diff/1/sky/engine/core/dom/Element.h#newcode94 sky/engine/core/dom/Element.h:94: Vector<RefPtr<Attr>> getAttributes(); On 2014/10/30 at 20:53:09, esprehn wrote: > ...

6 years, 1 month ago (2014-10-30 20:54:52 UTC) #3

abarth-chromium

ensureAttr should be const but do something with "mutable" or const_cast, but it calls a ...

6 years, 1 month ago (2014-10-30 20:55:48 UTC) #4

abarth-chromium

6 years, 1 month ago (2014-10-30 20:56:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bb10867436d7cf66a21af1508f0e1802f5d4c2cc (presubmit successful).

Expand Messages | Collapse Messages