Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: grit_info.py

Issue 691873002: Add support to override output_all_resource_defines from command line. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master
Patch Set: fix .grd, add testOutputAllResourceDefinesFalse Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « grit/tool/build_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit_info.py
diff --git a/grit_info.py b/grit_info.py
index 47a51f760b547d80c250b4f68ccd89815dfba0cd..ce52997991c3aee58546c5241b111ba4d334a59d 100755
--- a/grit_info.py
+++ b/grit_info.py
@@ -112,6 +112,12 @@ def DoMain(argv):
# line flags.
parser.add_option("-E", action="append", dest="build_env", default=[])
parser.add_option("-w", action="append", dest="whitelist_files", default=[])
+ parser.add_option("--output-all-resource-defines", action="store_true",
newt (away) 2014/11/03 19:00:46 These arguments don't seem necessary in this file,
lliabraa 2014/11/03 20:10:18 Correct...they're unused. However, the gyp/gn file
+ dest="output_all_resource_defines", default=True,
+ help="Unused")
newt (away) 2014/11/03 19:00:46 why help="Unused"?
lliabraa 2014/11/03 20:10:18 because the values of these parameters are not use
+ parser.add_option("--no-output-all-resource-defines", action="store_false",
+ dest="output_all_resource_defines", default=True,
+ help="Unused")
parser.add_option("-f", dest="ids_file",
default="GRIT_DIR/../gritsettings/resource_ids")
parser.add_option("-t", dest="target_platform", default=None)
« no previous file with comments | « grit/tool/build_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698