Add support to override output_all_resource_defines from command line.

grit_info.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''Tool to determine inputs and outputs of a grit file.
 '''
 
 import optparse
 import os
@@ skipping 94 matching lines @@
 
 def DoMain(argv):
   parser = optparse.OptionParser()
   parser.add_option("--inputs", action="store_true", dest="inputs")
   parser.add_option("--outputs", action="store_true", dest="outputs")
   parser.add_option("-D", action="append", dest="defines", default=[])
   # grit build also supports '-E KEY=VALUE', support that to share command
   # line flags.
   parser.add_option("-E", action="append", dest="build_env", default=[])
   parser.add_option("-w", action="append", dest="whitelist_files", default=[])
+  parser.add_option("--output-all-resource-defines", action="store_true",

[newt (away), 2014/11/03 19:00:46]

These arguments don't seem necessary in this file, since
--[no-]output-all-resource-defines doesn't affect the list of input or output
files. Similarly, -a and -h aren't arguments to grit_info, even though they're
arguments to grit build.

[lliabraa, 2014/11/03 20:10:18]

Correct...they're unused. However, the gyp/gn files define grit_defines
variables and send them to both grit.py and grit_info.py, so when I add
--output-all-resource-defines to the grit_defines so that the grit build command
gets it, gyp/gn also sends it to grit_info. Without this change to grit_info,
sending --[no-]output-all-resource-defines results in an error.

As for the -a and -h, it doesn't look like these args are ever used in a
grit_defines, so they're not sent to both python scripts.

I'd rather not touch the grit_action/grit_target gypi files (e.g. to support
grit_build_defines and grit_info_defines separately), so these new parameters
need to be handled somehow here. I suppose I could strip the new args from
|argv| before calling parser.parse_args(argv), but I'm not sure that's really
any better. WDYT?

+                    dest="output_all_resource_defines", default=True,
+                    help="Unused")

[newt (away), 2014/11/03 19:00:46]

why help="Unused"?

[lliabraa, 2014/11/03 20:10:18]

because the values of these parameters are not used by the script (see above).

+  parser.add_option("--no-output-all-resource-defines", action="store_false",
+                    dest="output_all_resource_defines", default=True,
+                    help="Unused")
   parser.add_option("-f", dest="ids_file",
                     default="GRIT_DIR/../gritsettings/resource_ids")
   parser.add_option("-t", dest="target_platform", default=None)
 
   options, args = parser.parse_args(argv)
 
   defines = {}
   for define in options.defines:
     name, val = util.ParseDefine(define)
     defines[name] = val
@@ skipping 47 matching lines @@
   except WrongNumberOfArguments, e:
     PrintUsage()
     print e
     return 1
   print result
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))