Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 691853003: Add kkimlabs@ as owner for enhanced bookmark bridges. (Closed)

Created:
6 years, 1 month ago by Kibeom Kim (inactive)
Modified:
6 years, 1 month ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add kkimlabs@ as owner for enhanced bookmark bridges. Missing enhanced bookmark owners coverage from https://codereview.chromium.org/682103003 NOTRY=true BUG=None Committed: https://crrev.com/94fb97ccb2cb313438fb6907d1935dc6e85fa7a2 Cr-Commit-Position: refs/heads/master@{#302173}

Patch Set 1 #

Patch Set 2 : remove empty line #

Patch Set 3 : remove empty lines #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A chrome/android/java/src/org/chromium/chrome/browser/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/android/enhanced_bookmarks/OWNERS View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
Kibeom Kim (inactive)
realized missing files when I tried to land https://codereview.chromium.org/693613003/ https://codereview.chromium.org/691853003/diff/40001/chrome/browser/android/enhanced_bookmarks/OWNERS File chrome/browser/android/enhanced_bookmarks/OWNERS (left): https://codereview.chromium.org/691853003/diff/40001/chrome/browser/android/enhanced_bookmarks/OWNERS#oldcode2 chrome/browser/android/enhanced_bookmarks/OWNERS:2: ...
6 years, 1 month ago (2014-10-30 21:48:12 UTC) #2
Yaron
lgtm
6 years, 1 month ago (2014-10-30 22:23:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691853003/40001
6 years, 1 month ago (2014-10-30 22:31:47 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 22:33:37 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 22:36:11 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/94fb97ccb2cb313438fb6907d1935dc6e85fa7a2
Cr-Commit-Position: refs/heads/master@{#302173}

Powered by Google App Engine
This is Rietveld 408576698