content/public/browser/web_contents_delegate.h - Issue 691823002: Add WebContents source to methods in WebContentsDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 691823002: Add WebContents source to methods in WebContentsDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prerender/prerender_manager.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_delegate.h

diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h

index bcd5caf609b2664c386a9aa47c463951077666ec..92c8dcd7f5678ed8c0533417b73cf5cc4bfdeaaf 100644

--- a/content/public/browser/web_contents_delegate.h

+++ b/content/public/browser/web_contents_delegate.h

@@ -176,7 +176,7 @@ class CONTENT_EXPORT WebContentsDelegate {

// Returns true if javascript dialogs and unload alerts are suppressed.

// Default is false.

- virtual bool ShouldSuppressDialogs();

+ virtual bool ShouldSuppressDialogs(WebContents* source);

// Returns whether pending NavigationEntries for aborted browser-initiated

// navigations should be preserved (and thus returned from GetVisibleURL).

@@ -342,7 +342,8 @@ class CONTENT_EXPORT WebContentsDelegate {

// Returns a pointer to a service to manage JavaScript dialogs. May return

// NULL in which case dialogs aren't shown.

- virtual JavaScriptDialogManager* GetJavaScriptDialogManager();

+ virtual JavaScriptDialogManager* GetJavaScriptDialogManager(

+ WebContents* source);

// Called when color chooser should open. Returns the opened color chooser.

// Returns NULL if we failed to open the color chooser (e.g. when there is a