content/shell/browser/shell.cc - Issue 691823002: Add WebContents source to methods in WebContentsDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell.cc

Issue 691823002: Add WebContents source to methods in WebContentsDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell.cc

diff --git a/content/shell/browser/shell.cc b/content/shell/browser/shell.cc

index c31028f6b51be8852a329e7a70cc6220efb32a41..58b53e2d11ed169ca37c0c6a328bd1d2942510f1 100644

--- a/content/shell/browser/shell.cc

+++ b/content/shell/browser/shell.cc

@@ -329,7 +329,8 @@ void Shell::DidNavigateMainFramePostCommit(WebContents* web_contents) {

PlatformSetAddressBarURL(web_contents->GetLastCommittedURL());

}

-JavaScriptDialogManager* Shell::GetJavaScriptDialogManager() {

+JavaScriptDialogManager* Shell::GetJavaScriptDialogManager(

+ WebContents* source) {

if (!dialog_manager_) {

const CommandLine& command_line = *CommandLine::ForCurrentProcess();

dialog_manager_.reset(command_line.HasSwitch(switches::kDumpRenderTree)

« no previous file with comments | « content/shell/browser/shell.h ('k') | extensions/browser/app_window/app_window.h » ('j') | no next file with comments »