content/browser/devtools/protocol/page_handler.cc - Issue 691823002: Add WebContents source to methods in WebContentsDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 691823002: Add WebContents source to methods in WebContentsDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_sensors/device_inertial_sensor_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/page_handler.cc

diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc

index f16150b1b94e39e016b05eb26c50b8824565e431..2a1ace9647326e34bbfde1e7e7e7719a8a155d48 100644

--- a/content/browser/devtools/protocol/page_handler.cc

+++ b/content/browser/devtools/protocol/page_handler.cc

@@ -373,7 +373,7 @@ Response PageHandler::HandleJavaScriptDialog(bool accept,

return Response::InternalError("No JavaScript dialog to handle");

JavaScriptDialogManager* manager =

- web_contents->GetDelegate()->GetJavaScriptDialogManager();

+ web_contents->GetDelegate()->GetJavaScriptDialogManager(web_contents);

if (manager && manager->HandleJavaScriptDialog(

web_contents, accept, prompt_text ? &prompt_override : nullptr)) {

return Response::OK();