net/base/address_tracker_linux_unittest.cc - Issue 691783003: [WIP NOT FOR COMMIT] Switch Android to libc++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/address_tracker_linux_unittest.cc

Issue 691783003: [WIP NOT FOR COMMIT] Switch Android to libc++ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/address_tracker_linux_unittest.cc

diff --git a/net/base/address_tracker_linux_unittest.cc b/net/base/address_tracker_linux_unittest.cc

index 641220731b71bbbe43b54f4e8b564921494f5b64..ea5353369c504807eb4f701014695f10729275c0 100644

--- a/net/base/address_tracker_linux_unittest.cc

+++ b/net/base/address_tracker_linux_unittest.cc

@@ -142,7 +142,7 @@ class NetlinkMessage {

return reinterpret_cast<struct nlmsghdr*>(&buffer_[0]);

}

- Buffer buffer_;

+ std::vector<int8_t> buffer_;

Fabrice (no longer in Chrome) 2014/11/12 11:52:29 Sorry, I missed it. This only fails with GCC, Clan

};

#define INFINITY_LIFE_TIME 0xFFFFFFFF