Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 691783002: Add SkDocument::getStream() method. (Closed)

Created:
6 years, 1 month ago by hal.canary
Modified:
6 years, 1 month ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add SkDocument::getStream() method. Motivation: SkDocument_PDF can be refactored to stream all PDF objects as SkCanvas calls are made, to save memory! BUG=skia:3030 BUG=skia:2683 Committed: https://skia.googlesource.com/skia/+/902d4d18dec27b6991516a235fc04a7af7290287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/core/SkDocument.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hal.canary
6 years, 1 month ago (2014-10-30 14:16:55 UTC) #2
reed1
lgtm
6 years, 1 month ago (2014-10-30 14:35:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691783002/1
6 years, 1 month ago (2014-10-30 14:45:52 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:29:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 902d4d18dec27b6991516a235fc04a7af7290287

Powered by Google App Engine
This is Rietveld 408576698