chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc - Issue 691703002: Modified DialogDelegateView to be accessible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

Issue 691703002: Modified DialogDelegateView to be accessible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a check to GetWidget() as well Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

index f7cf5db13bfe4386774f0bd1e5c06fd28697879c..ada02d38baa5f6044f802b5fee852b72e957a970 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

@@ -168,9 +168,9 @@ bool BookmarkEditorView::HandleKeyEvent(views::Textfield* sender,

}

void BookmarkEditorView::GetAccessibleState(ui::AXViewState* state) {

+ views::DialogDelegateView::GetAccessibleState(state);

state->name =

l10n_util::GetStringUTF16(IDS_BOOKMARK_EDITOR_TITLE);

- state->role = ui::AX_ROLE_DIALOG;

}

void BookmarkEditorView::ButtonPressed(views::Button* sender,