Modified DialogDelegateView to be accessible

ui/views/window/dialog_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WINDOW_DIALOG_DELEGATE_H_
 #define UI_VIEWS_WINDOW_DIALOG_DELEGATE_H_
 
 #include "base/compiler_specific.h"
 #include "base/strings/string16.h"
 #include "ui/accessibility/ax_enums.h"
@@ skipping 119 matching lines @@
   DialogDelegateView();
   ~DialogDelegateView() override;
 
   // Overridden from DialogDelegate:
   void DeleteDelegate() override;
   Widget* GetWidget() override;
   const Widget* GetWidget() const override;
   View* GetContentsView() override;
 
  private:
+  // Overridden from View:

[sky, 2014/10/30 13:13:28]

I don't think either of these should be private. Subclasses may want to
override. In fact you need to investigate all subclasses and make sure if one is
overriding they are invoking DialogDelegateView::Foo.

[sashab, 2014/10/30 23:12:02]

Looking at all the direct subclasses, the following override
ViewHierarchyChanged:
- NetworkConfigView
- CollectedCookieView
- ExtensionInstallDialogView
- HungRendererView
- ProfileSigninConfirmationDialogViews
- SignedCertificateTimestampsViews
- TaskManagerView
I have updated these to call the parent ViewHierarchyChanged. I don't know an
easy way to search through all their subclasses recursively... to find all
classes that override ViewHierarchyChanged that also indirectly inherit from
DialogDelegateView.

The following override GetAccessibleState:
- NetworkConfigView
- BookmarkEditorView
However, I've left them as they are since they override GetWindowTitle() to use
a different title (they want to display one title but have a different one for
accessibility purposes). Made them call the parent class just to remove the
repeated 'role = AX_ROLE_DIALOG' code.

+  void GetAccessibleState(ui::AXViewState* state) override;
+  void ViewHierarchyChanged(
+      const ViewHierarchyChangedDetails& details) override;
+
   DISALLOW_COPY_AND_ASSIGN(DialogDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WINDOW_DIALOG_DELEGATE_H_