src/IceCfg.cpp - Issue 691693003: Subzero: Improve the representation and handling of the FakeKill instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 691693003: Subzero: Improve the representation and handling of the FakeKill instruction. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Simplify special-casing of the FakeKills Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index b8b5ce38454d811f701d61441a2c7a7a469db5e4..ab9d5f724e826babb9e60a9315faf5928ebd5a7c 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -316,8 +316,6 @@ bool Cfg::validateLiveness() const {

for (Inst *Inst : Node->getInsts()) {

if (Inst->isDeleted())

continue;

- if (llvm::isa<InstFakeKill>(Inst))

- continue;

if (FirstInst == NULL)

FirstInst = Inst;

InstNumberT InstNumber = Inst->getNumber();

« no previous file with comments | « no previous file | src/IceCfgNode.cpp » ('j') | src/IceTargetLoweringX8632.cpp » ('J')