Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 691683002: Wait 60s instead of 30s for browser to launch. (Closed)

Created:
6 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
nednguyen, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, nednguyen, dtu, jbauman, hendrikw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Wait 60s instead of 30s for browser to launch. There's a guess that the browser may be launching extremely slowly on some bots and that when the browser main process is killed it's leaking sub-processes that are in the middle of being spawned. Increase the timeout to try to confirm this hypothesis. BUG=424024 R=tonyg@chromium.org Committed: https://crrev.com/7ef2c0036f70bdcc59dd7c8f23c8b7c5a3f114d9 Cr-Commit-Position: refs/heads/master@{#302087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Ken Russell (switch to Gerrit)
Tony or Ned or David: please review. Thanks.
6 years, 1 month ago (2014-10-30 02:16:18 UTC) #1
tonyg
lgtm But let's revert if this doesn't fix things.
6 years, 1 month ago (2014-10-30 02:50:45 UTC) #2
Ken Russell (switch to Gerrit)
OK. Thanks.
6 years, 1 month ago (2014-10-30 02:58:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691683002/1
6 years, 1 month ago (2014-10-30 02:58:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/6806)
6 years, 1 month ago (2014-10-30 04:08:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691683002/1
6 years, 1 month ago (2014-10-30 14:44:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 15:28:23 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7ef2c0036f70bdcc59dd7c8f23c8b7c5a3f114d9 Cr-Commit-Position: refs/heads/master@{#302087}
6 years, 1 month ago (2014-10-30 15:29:08 UTC) #11
Ken Russell (switch to Gerrit)
6 years, 1 month ago (2014-10-30 19:17:48 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/667733004/ by kbr@chromium.org.

The reason for reverting is: Didn't help -- stuck subprocesses are still showing
up.
.

Powered by Google App Engine
This is Rietveld 408576698