sky/engine/bindings/core/v8/V8ScriptRunner.cpp - Issue 691663002: Unfork Sky's trace events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/V8ScriptRunner.cpp

Issue 691663002: Unfork Sky's trace events (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/bindings/core/v8/V8ScriptRunner.cpp

diff --git a/sky/engine/bindings/core/v8/V8ScriptRunner.cpp b/sky/engine/bindings/core/v8/V8ScriptRunner.cpp

index 33e8faef7ed871bb79f7789ff72c77a7c799b8e1..9f6d746bf73117c74f057db1ed4c52a9347bab47 100644

--- a/sky/engine/bindings/core/v8/V8ScriptRunner.cpp

+++ b/sky/engine/bindings/core/v8/V8ScriptRunner.cpp

@@ -69,7 +69,7 @@ v8::Local<v8::Script> V8ScriptRunner::compileScript(const ScriptSourceCode& sour

v8::Local<v8::Script> V8ScriptRunner::compileScript(v8::Handle<v8::String> code, const String& fileName, const TextPosition& scriptStartPosition, v8::Isolate* isolate, V8CacheOptions cacheOptions)

{

- TRACE_EVENT1("v8", "v8.compile", "fileName", fileName.utf8());

+ TRACE_EVENT1("v8", "v8.compile", "fileName", fileName.utf8().data());

TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Compile");

// NOTE: For compatibility with WebCore, ScriptSourceCode's line starts at

« no previous file with comments | « sky/engine/bindings/core/v8/V8GCController.cpp ('k') | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »