Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 691663002: Unfork Sky's trace events (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Unfork Sky's trace events This CL remove the body of Sky's TraceEvent.h in favor of the version in base. There's still some more of the system to unwind before we can remove all the other boilerplate. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b19847f8804c28021298da916f0e7fa8dc83ffe0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1079 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/V8GCController.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M sky/engine/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/ScriptedAnimationController.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M sky/engine/core/events/EventDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/GenericEventQueue.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/ConsoleBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/DOMTimer.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/loader/FrameFetchContext.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/EventTracer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/TraceEvent.h View 1 chunk +4 lines, -1013 lines 0 comments Download
M sky/engine/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/OpaqueRectTrackingContentLayerDelegate.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
6 years, 1 month ago (2014-10-29 23:58:47 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-30 00:06:01 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-10-30 00:09:40 UTC) #5
abarth-chromium
6 years, 1 month ago (2014-10-30 16:39:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b19847f8804c28021298da916f0e7fa8dc83ffe0.

Powered by Google App Engine
This is Rietveld 408576698