Issue 691623003: Remove Platform::parseDataURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 691623003: Remove Platform::parseDataURL (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove Platform::parseDataURL We only use this data URL parser to pre-cache images loaded from data URLs. It's not clear we need that optimization in this system. If we do want it, we can just call the data URL parser directly. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cb0fa139c80be5614ea40248a3b52a03108deee6

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -76 lines)			Patch
M	sky/engine/core/fetch/ResourceFetcher.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/fetch/ResourceFetcher.cpp	View	2 chunks	+0 lines, -38 lines	0 comments	Download
M	sky/engine/public/platform/Platform.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/testing/platform/platform_impl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/testing/platform/platform_impl.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	sky/viewer/platform/platform_impl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/viewer/platform/platform_impl.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

6 years, 1 month ago (2014-10-30 00:09:38 UTC) #5

abarth-chromium

6 years, 1 month ago (2014-10-30 16:41:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cb0fa139c80be5614ea40248a3b52a03108deee6.