Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 691593002: Fix OpenSSL x509 unit test build breakage by adding a missing getter for a scoped_refptr. (Closed)

Created:
6 years, 1 month ago by Kevin M
Modified:
6 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix OpenSSL x509 unit test build breakage by adding a missing getter for a scoped_refptr. R=sleevi@chromium.org,davidben@chromium.org CC=cloudview-eng BUG= Committed: https://crrev.com/8e53e464d828dd6e56775b28cb17ad0fe5bca11c Cr-Commit-Position: refs/heads/master@{#302100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/net/x509_certificate_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Kevin Marshall
6 years, 1 month ago (2014-10-29 18:04:47 UTC) #3
Ryan Sleevi
This LGTM, but that you ran into it tells me that you're doing something not ...
6 years, 1 month ago (2014-10-29 18:07:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691593002/1
6 years, 1 month ago (2014-10-30 16:32:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 17:40:19 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 17:41:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e53e464d828dd6e56775b28cb17ad0fe5bca11c
Cr-Commit-Position: refs/heads/master@{#302100}

Powered by Google App Engine
This is Rietveld 408576698