Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 691583002: Retry failing tests on Safari, because it is flaky. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index fd2922090313ec6e541fcf8600057fd9ecb81331..befa478fe6b86a455ff86d1bbbff190801136335 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2581,6 +2581,13 @@ class ReplayingCommandExecutor implements CommandExecutor {
bool shouldRetryCommand(CommandOutput output) {
var command = output.command;
+ // We rerun tests on Safari because 6.2 and 7.1 are flaky. Issue 21434.
+ if (command is BrowserTestCommand && command.browser == 'safari' &&
+ output is BrowserControllerTestOutcome &&
+ output._rawOutcome != Expectation.PASS) {
+ // TODO(whesse): This retries tests that fail intentionally. Fix this
+ return true;
+ }
if (!output.successful) {
List<String> stdout, stderr;
@@ -2606,9 +2613,7 @@ bool shouldRetryCommand(CommandOutput output) {
}
// We currently rerun dartium tests, see issue 14074.
- // We rerun tests on Safari because 6.2 and 7.1 are flaky. Issue 21434.
- if (command is BrowserTestCommand &&
- (command.browser == 'dartium' || command.browser == 'safari')) {
+ if (command is BrowserTestCommand && command.browser == 'dartium') {
return true;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698