Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 691573003: Split out mojo_converters into its own target. (Closed)

Created:
6 years, 1 month ago by DaleCurtis
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Split out mojo_converters into its own target. The mojo_surface_converters get their own file to avoid dependency cycles between media/ and cc/ BUG=none TEST=no more cycles when media depends on type conveters. Committed: https://crrev.com/6cdbabebc60c42a496af70fa7a6792454d05ecb9 Cr-Commit-Position: refs/heads/master@{#302367}

Patch Set 1 : Similarity fix. #

Patch Set 2 : Explode! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -209 lines) Patch
M mojo/mojo.gyp View 1 2 chunks +4 lines, -5 lines 0 comments Download
D mojo/mojo_converters.gypi View 1 chunk +0 lines, -140 lines 0 comments Download
A mojo/mojo_geometry_converters.gyp View 1 1 chunk +41 lines, -0 lines 0 comments Download
A mojo/mojo_input_events_converters.gyp View 1 1 chunk +42 lines, -0 lines 0 comments Download
A + mojo/mojo_surface_converters.gyp View 1 3 chunks +6 lines, -64 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
DaleCurtis
6 years, 1 month ago (2014-10-31 20:30:46 UTC) #3
jamesr
Rather than having mojo_converters.gyp which has input_event and geometry converters and mojo_surfaces_converters.gyp, can we have ...
6 years, 1 month ago (2014-10-31 23:34:08 UTC) #4
DaleCurtis
Done.
6 years, 1 month ago (2014-10-31 23:59:50 UTC) #6
jamesr
lgtm
6 years, 1 month ago (2014-11-01 00:05:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691573003/60001
6 years, 1 month ago (2014-11-01 00:07:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 1 month ago (2014-11-01 00:49:42 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:50:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cdbabebc60c42a496af70fa7a6792454d05ecb9
Cr-Commit-Position: refs/heads/master@{#302367}

Powered by Google App Engine
This is Rietveld 408576698