Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 691563002: MIPS: EmitCreateIteratorResult loads map from function's context. (Closed)

Created:
6 years, 1 month ago by balazs.kilvady
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: EmitCreateIteratorResult loads map from function's context. Port r24987 (cfc4713) Original commit message: Caching or serialization can cause full-codegen output to be shared between contexts. CreateIteratorResult, however, was doing the wrong thing by creating results with the map that was current when the code was generated. Instead, we should chase pointers to load the right map from the function's context. BUG=v8:3656 LOG=N R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=24993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
balazs.kilvady
6 years, 1 month ago (2014-10-29 17:47:02 UTC) #2
paul.l...
lgtm
6 years, 1 month ago (2014-10-29 18:12:56 UTC) #3
balazs.kilvady
6 years, 1 month ago (2014-10-29 18:20:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698