Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 691553002: Refactoring auto-bisect bot (Closed)

Created:
6 years, 1 month ago by Sergiy Byelozyorov
Modified:
6 years, 1 month ago
Reviewers:
qyearsley
CC:
chromium-reviews, RobertoCN, prasadv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactoring auto-bisect bot - BisectPerformanceMetrics class: - Added src_cwd to constructor to allow easier mocking. Using os.getcwd() creates non-obvious expectations from the caller. - Exposed printer field to allow it being reused outside. - Added a comment explaining arguments to the constructor. - BisectOptions class: - Changed from deprecated optparse to argparse - Split _CreateCommandLineParser - Moved logic from ParseCommandLine to argparse where possible - Removed code related to ChromeOS BUG=425652 R=qyearsley@chromium.org CC=ojan@chromium.org Committed: https://crrev.com/9cf2803cdd2ae9bb74a2e42231d9bcb1f8b8e4f5 Cr-Commit-Position: refs/heads/master@{#302256}

Patch Set 1 #

Patch Set 2 : Refactored BisectOptions #

Patch Set 3 : Removed code related to ChromeOS #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -596 lines) Patch
M tools/auto_bisect/bisect.cfg View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression.py View 1 2 3 24 chunks +151 lines, -352 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 1 2 3 5 chunks +3 lines, -9 lines 0 comments Download
M tools/auto_bisect/bisect_utils.py View 1 2 3 3 chunks +1 line, -71 lines 0 comments Download
M tools/auto_bisect/builder.py View 1 2 3 4 chunks +1 line, -111 lines 0 comments Download
M tools/auto_bisect/source_control.py View 1 2 5 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Sergiy Byelozyorov
6 years, 1 month ago (2014-10-29 15:29:24 UTC) #1
qyearsley
On 2014/10/29 15:29:24, Sergiy Byelozyorov wrote: LGTM :-D This CL is quite large and involves ...
6 years, 1 month ago (2014-10-31 05:41:40 UTC) #2
Sergiy Byelozyorov
On 2014/10/31 05:41:40, qyearsley wrote: > On 2014/10/29 15:29:24, Sergiy Byelozyorov wrote: > > LGTM ...
6 years, 1 month ago (2014-10-31 13:11:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691553002/60001
6 years, 1 month ago (2014-10-31 13:11:38 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-31 13:52:20 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 13:53:04 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9cf2803cdd2ae9bb74a2e42231d9bcb1f8b8e4f5
Cr-Commit-Position: refs/heads/master@{#302256}

Powered by Google App Engine
This is Rietveld 408576698