Issue 691513005: remove some isolate::currents from api.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 691513005: remove some isolate::currents from api.cc (Closed)

Created:
6 years, 1 month ago by dcarney

Modified:
6 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

remove some isolate::currents from api.cc R=svenpanne@chromium.org BUG=

Patch Set 2 : #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	src/api.cc	View	1	3 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sven Panne

LGTM with a nit. https://codereview.chromium.org/691513005/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/691513005/diff/1/src/api.cc#newcode3035 src/api.cc:3035: } Shorter and more readable ...

6 years, 1 month ago (2014-11-06 07:29:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691513005/20001

6 years ago (2014-11-24 09:13:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 691513005: remove some isolate::currents from api.cc (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages