Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 691493005: Code readability patch, removed extra returned statements from code (Closed)

Created:
6 years, 1 month ago by h.joshi
Modified:
6 years, 1 month ago
Reviewers:
Timothy Loh, eae
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Code readability patch, removed extra returned statements from code Layout test not needed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184855

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comment fix #

Patch Set 3 : Fixing Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 2 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
h.joshi
@Emil: Pls review
6 years, 1 month ago (2014-10-31 04:32:12 UTC) #2
Timothy Loh
https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp File Source/core/css/CSSFontFaceSrcValue.cpp (right): https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp#newcode47 Source/core/css/CSSFontFaceSrcValue.cpp:47: return !(!m_resource.startsWith("data:", false) && m_resource.endsWith(".eot", false)); // Check for ...
6 years, 1 month ago (2014-10-31 05:53:31 UTC) #4
h.joshi
@Timothy Loh: Made suggested changes. Pls review. https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp File Source/core/css/CSSFontFaceSrcValue.cpp (right): https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp#newcode47 Source/core/css/CSSFontFaceSrcValue.cpp:47: return !(!m_resource.startsWith("data:", ...
6 years, 1 month ago (2014-10-31 08:58:04 UTC) #5
h.joshi
Pls review
6 years, 1 month ago (2014-11-03 17:09:53 UTC) #6
Timothy Loh
https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp File Source/core/css/CSSFontFaceSrcValue.cpp (right): https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp#newcode47 Source/core/css/CSSFontFaceSrcValue.cpp:47: return !(!m_resource.startsWith("data:", false) && m_resource.endsWith(".eot", false)); // Check for ...
6 years, 1 month ago (2014-11-03 17:15:42 UTC) #7
h.joshi
On 2014/11/03 17:15:42, Timothy Loh wrote: > https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp > File Source/core/css/CSSFontFaceSrcValue.cpp (right): > > https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceSrcValue.cpp#newcode47 ...
6 years, 1 month ago (2014-11-04 07:08:40 UTC) #8
h.joshi
Made required changes (previous msg went without my comments, please ignore that)
6 years, 1 month ago (2014-11-04 07:09:58 UTC) #9
Timothy Loh
On 2014/11/04 07:09:58, h.joshi wrote: > Made required changes > (previous msg went without my ...
6 years, 1 month ago (2014-11-04 17:24:23 UTC) #10
h.joshi
@Timothy Loh: Thank you
6 years, 1 month ago (2014-11-05 01:44:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691493005/40001
6 years, 1 month ago (2014-11-05 01:45:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/32258)
6 years, 1 month ago (2014-11-05 01:53:30 UTC) #15
h.joshi
@Timothy Loh: Pls re-review patch, previous uploaded patch got deleted.
6 years, 1 month ago (2014-11-05 04:14:30 UTC) #17
Timothy Loh
On 2014/11/05 04:14:30, h.joshi wrote: > @Timothy Loh: Pls re-review patch, previous uploaded patch got ...
6 years, 1 month ago (2014-11-05 04:23:49 UTC) #18
h.joshi
@Timothy Loh: Thank you
6 years, 1 month ago (2014-11-05 06:07:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691493005/60001
6 years, 1 month ago (2014-11-05 06:07:35 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 08:13:40 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as 184855

Powered by Google App Engine
This is Rietveld 408576698