Code readability patch, removed extra returned statements from code

Code readability patch, removed extra returned statements from code

Layout test not needed.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184855

[h.joshi, 2014-10-31 04:31:58]

h.joshi@samsung.com changed reviewers:
+ eae@chromium.org

[h.joshi, 2014-10-31 04:32:12]

@Emil: Pls review

[Timothy Loh, 2014-10-31 05:53:31]

timloh@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2014-10-31 05:53:31]

https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
File Source/core/css/CSSFontFaceSrcValue.cpp (right):

https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
Source/core/css/CSSFontFaceSrcValue.cpp:47: return
!(!m_resource.startsWith("data:", false) && m_resource.endsWith(".eot", false));
// Check for .eot.
How about:
return m_resource.startsWith("data:", false) || !m_resource.endsWith(".eot",
false));

The comment "Check for .eot" doesn't seem useful given the above comment.

[h.joshi, 2014-10-31 08:58:04]

@Timothy Loh: Made suggested changes.
Pls review.

https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
File Source/core/css/CSSFontFaceSrcValue.cpp (right):

https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
Source/core/css/CSSFontFaceSrcValue.cpp:47: return
!(!m_resource.startsWith("data:", false) && m_resource.endsWith(".eot", false));
// Check for .eot.
On 2014/10/31 05:53:31, Timothy Loh wrote:
> How about:
> return m_resource.startsWith("data:", false) || !m_resource.endsWith(".eot",
> false));
> 
> The comment "Check for .eot" doesn't seem useful given the above comment.

Done.

[h.joshi, 2014-11-03 17:09:53]

Pls review

[Timothy Loh, 2014-11-03 17:15:42]

https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
File Source/core/css/CSSFontFaceSrcValue.cpp (right):

https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
Source/core/css/CSSFontFaceSrcValue.cpp:47: return
!(!m_resource.startsWith("data:", false) && m_resource.endsWith(".eot", false));
// Check for .eot.
On 2014/10/31 08:58:04, h.joshi wrote:
> On 2014/10/31 05:53:31, Timothy Loh wrote:
> > How about:
> > return m_resource.startsWith("data:", false) || !m_resource.endsWith(".eot",
> > false));
> > 
> > The comment "Check for .eot" doesn't seem useful given the above comment.
> 
> Done.

You didn't change the && to || here.

[h.joshi, 2014-11-04 07:08:40]

On 2014/11/03 17:15:42, Timothy Loh wrote:
>
https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
> File Source/core/css/CSSFontFaceSrcValue.cpp (right):
> 
>
https://codereview.chromium.org/691493005/diff/1/Source/core/css/CSSFontFaceS...
> Source/core/css/CSSFontFaceSrcValue.cpp:47: return
> !(!m_resource.startsWith("data:", false) && m_resource.endsWith(".eot",
false));
> // Check for .eot.
> On 2014/10/31 08:58:04, h.joshi wrote:
> > On 2014/10/31 05:53:31, Timothy Loh wrote:
> > > How about:
> > > return m_resource.startsWith("data:", false) ||
!m_resource.endsWith(".eot",
> > > false));
> > > 
> > > The comment "Check for .eot" doesn't seem useful given the above comment.
> > 
> > Done.
> 
> You didn't change the && to || here.

[h.joshi, 2014-11-04 07:09:58]

Made required changes
(previous msg went without my comments, please ignore that)

[Timothy Loh, 2014-11-04 17:24:23]

On 2014/11/04 07:09:58, h.joshi wrote:
> Made required changes
> (previous msg went without my comments, please ignore that)

ok, lgtm

[h.joshi, 2014-11-05 01:44:47]

@Timothy Loh: Thank you

[h.joshi, 2014-11-05 01:44:52]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-11-05 01:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691493005/40001

[commit-bot: I haz the power, 2014-11-05 01:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-05 01:53:30]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[h.joshi, 2014-11-05 04:03:13]

Patchset #3 (id:40001) has been deleted

[h.joshi, 2014-11-05 04:14:30]

@Timothy Loh: Pls re-review patch, previous uploaded patch got deleted.

[Timothy Loh, 2014-11-05 04:23:49]

On 2014/11/05 04:14:30, h.joshi wrote:
> @Timothy Loh: Pls re-review patch, previous uploaded patch got deleted.

Still lgtm.

[h.joshi, 2014-11-05 06:07:21]

@Timothy Loh: Thank you

[h.joshi, 2014-11-05 06:07:27]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-11-05 06:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691493005/60001

[commit-bot: I haz the power, 2014-11-05 08:13:40]

Committed patchset #3 (id:60001) as 184855