Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 691493004: Remove callOnMainThread (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove callOnMainThread This API is redundant with exposing the main-thread task runner. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e7a3e529caebb10cf097444ce7ad917185b4740c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -42 lines) Patch
M sky/engine/platform/SharedBuffer.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M sky/engine/platform/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/platform/Platform.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/Sky.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/engine/wtf/MainThread.h View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/wtf/MainThread.cpp View 1 chunk +1 line, -9 lines 0 comments Download
M sky/engine/wtf/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/text/StringImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
6 years, 1 month ago (2014-10-29 23:25:43 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-30 00:04:25 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-10-30 00:04:34 UTC) #5
abarth-chromium
6 years, 1 month ago (2014-10-30 16:40:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7a3e529caebb10cf097444ce7ad917185b4740c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698