Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 691483005: Remove Platform::cryptographicallyRandomValues (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove Platform::cryptographicallyRandomValues We can just call the base API directly. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/541db22fec3ff8918e653c0fff560e67958a0b05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -27 lines) Patch
M sky/engine/core/animation/CompositorAnimationsTestHelper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/fetch/CachingCorrectnessTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/TestingPlatformSupport.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/TestingPlatformSupport.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/fonts/FontCacheTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/platform/Platform.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/Sky.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-29 22:45:15 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-29 22:54:29 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-29 22:55:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
541db22fec3ff8918e653c0fff560e67958a0b05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698